…sk-209, phase 4)

Completes task-209 by setting the ChatMessageContext analytics booleans
at their assembly sites, instrumenting SemanticSearchService and
SubAgentRunner, updating the three disclosure surfaces in lockstep, and
shipping the shared GA4 schema doc.

Context set-sites (AC #25)
- ChatMessageContextUtil.setWindowContext(): flips projectContextFullUsed
  when full project is attached; processAttachedFiles() flips
  projectContextSelectedUsed when non-empty attached files are queued.
- ChatMemoryManager.buildSystemPrompt(context): mirrors the
  useDevoxxGenieMdInPrompt + file-present gate to set devoxxGenieMdUsed.

Semantic search (AC #20)
- SemanticSearchService.search() now fires FeatureUsageTracker
  .semanticSearchUsed at invocation — query text never leaves the IDE.

Sub-agent analytics (AC #23 subtlety)
- SubAgentRunner emits its own agent feature_used event in a finally
  block so success/error/cancellation all go through. Uses
  ProviderType.fromModelProvider derived from resolvedProviderName, with
  a safe fallback to ProviderType.NONE on unknown provider strings. Sub-
  agent events are separate from parent events so the parent isn't
  double-counted.

Disclosure lockstep (ACs #11, #27)
- AnalyticsConsentNotifier: new first-run bullets covering feature
  enablement snapshot + per-prompt usage, and the "never sent" list is
  extended with MCP server names/URLs/commands/tool names and custom
  prompt names/bodies.
- GeneralSettingsComponent: matching sent/not-sent bullets in the
  settings panel.
- plugin.xml: marketplace description updated to match, and the
  Settings path is now "DevoxxGenie → Analytics" (matching the
  existing panel rename).

Schema doc (AC #13)
- docs/analytics-schema.md: single source of truth for the GA4 schema
  shared with GenieBuilder — event shapes, common params, closed
  feature_id enum, provider_type mapping (including OPTIONAL → cloud),
  both bucket ladders, and a change-process checklist.

GenieBuilder follow-up (AC #14)
- Filed task-210 in this repo's backlog as the admin-UI follow-up,
  with dependency → task-209, closed enum references, and explicit
  out-of-scope rules (never display free-form MCP server or custom
  prompt values).

Tests
- FeatureUsageTrackerTest: guardrails asserting every FeatureId wire
  value matches the schema doc, the usage-only flag is set on exactly
  the four documented ids, fromWireValue round-trips, and
  semanticSearchUsed(null) is fail-silent.

Task-209 ACs are 27/28. AC #12's explicit task-208 offline-fire-and-
forget regression is covered implicitly by the existing
AnalyticsServiceTest.asyncNetworkFailureIsSilent which now runs through
the refactored AnalyticsEventBuilder path.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

All findings from the second review round are fixed and the full test
suite is green.

#1 MCP-inside-agent not counted
- AgentToolProviderFactory.createToolProvider now has an overload taking
  an optional AtomicInteger mcpCallCounter and threads it into
  MCPExecutionService.createRawMCPToolProvider(counter), so agent-hosted
  MCP invocations also go through InstrumentedMcpToolProvider.
- StreamingPromptStrategy and NonStreamingPromptExecutionService pass
  context.getMcpCallCount() into the new overload.

#2 RAG/WebSearch activation flags were never set on ChatMessageContext
- SearchOptionsPanel writes ragActivated/webSearchActivated to
  DevoxxGenieStateService but ChatMessageContext.ragActivated/
  webSearchActivated were always false. ChatMessageContextUtil.createContext
  now mirrors both flags from state onto the context so
  FeatureUsageTracker.emitForPrompt fires the rag and web_search_*
  events as designed.

#3 Snapshot one-shot consumed before consent
- AnalyticsSessionSnapshotService.snapshotIfNeeded now preflights
  analyticsNoticeAcknowledged + analyticsEnabled BEFORE
  compareAndSet(false, true). The first opted-in session still emits
  after "OK, Keep Enabled" is clicked because the guard never fired.

#4 Settings-change re-arm missing from RAG/MCP/WebSearch/Agent panels
- Extracted a fail-silent helper
  DevoxxGenieSettingsChangedTopic.notifySettingsChanged() and wired it
  into every relevant apply() method: GeneralSettingsComponent,
  RAGSettingsConfigurable, MCPSettingsComponent, WebSearchProviders-
  Configurable, AgentSettingsComponent. The helper swallows any
  exception (including null MessageBus in test environments) so
  settings apply() paths never crash because analytics is unreachable.

#5 Windows drive-letter absolute paths not rejected
- AnalyticsEventBuilder.rejectShape now also drops values matching the
  pattern `[A-Za-z]:[/\\].*`, plus four new unit tests covering
  backslash, forward-slash, lowercase drive letters, and the existing
  UNC path case.

#6 Semantic search usage emitted provider_type=none
- Moved the FeatureUsageTracker.semanticSearchUsed call out of
  SemanticSearchService.search and into MessageCreationService where
  the active LanguageModel is in scope. The event now reflects the
  real provider.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>